Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid wide strings (UTF-16) handling #306

Open
TheBestTvarynka opened this issue Oct 15, 2024 · 0 comments
Open

Fix invalid wide strings (UTF-16) handling #306

TheBestTvarynka opened this issue Oct 15, 2024 · 0 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@TheBestTvarynka
Copy link
Collaborator

Usually, we multiply the chars count by 2 to calculate the total bytes in the wide string. For example,

sspi-rs/ffi/src/sspi/sec_winnt_auth_identity.rs

Line 323 in bef5fd2

domain: raw_str_into_bytes((*auth_data).domain as *const _, (*auth_data).domain_length as usize * 2),

Read this thread for more details: #304 (comment)

In the scope of this issue, we need to fix it.
@TheBestTvarynka TheBestTvarynka mentioned this issue Oct 15, 2024
Merged
@CBenoit CBenoit changed the title Refactor: fix invalid wide strings handling Fix invalid wide strings (UTF-16) handling Oct 15, 2024
@CBenoit CBenoit added bug Something isn't working invalid This doesn't seem right labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working invalid This doesn't seem right
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CBenoit @TheBestTvarynka