Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the Overlapping of Password Visibility Toggle Fields on First… #811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shivraj-yadav
Copy link

Description
This pull request addresses the issue where the password visibility toggle fields overlap during the first input. The overlapping was caused by the incorrect implementation of the HTML tag used for the toggle icons.

Changes Made:
Adjusted HTML Structure: Modified the tag for better spacing and alignment to ensure that the "Show Password" and "Hide Password" icons are displayed correctly.

Motivation and Context:
This improvement enhances the user experience by providing a clear and distinct visual cue when toggling the password visibility, eliminating confusion for users.

Related Issue:
Fixes #809
Closes #809

Type of Change

  • [✔️ ] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ ✔️] My code follows the style guidelines of this project
  • [✔️ ] I have performed a self-review of my own code
  • [ ✔️] I have commented my code, particularly in hard-to-understand areas
  • [ ✔️] I have made corresponding changes to the documentation
  • [ ✔️] My changes generate no new warnings
  • [ ✔️] I have added tests that prove my fix is effective or that my feature works
  • [ ✔️] New and existing unit tests pass locally with my changes
  • [ ✔️] Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video

image

… Input

I have resolved the overlapping issue of the password visibility toggle fields by adjusting the HTML <i> tag
Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ice-cream-parlour-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 9:57am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @shivraj-yadav for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@shivraj-yadav
Copy link
Author

Hi team,

I’ve implemented the changes to resolve the overlapping issue with the password visibility toggle fields by adjusting the HTML tag. This should ensure that the "Show Password" and "Hide Password" icons display correctly without any overlap during user interaction.

Please take a look at the adjustments made and let me know if you have any suggestions or further improvements. I'm looking forward to your feedback!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Password Visibility Toggle Icon Overlapping with Input Field on First Entry
1 participant