Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow further epics options in datatypes #63

Open
evalott100 opened this issue Oct 15, 2024 · 3 comments
Open

Allow further epics options in datatypes #63

evalott100 opened this issue Oct 15, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@evalott100
Copy link
Contributor

Currently you can pass general information to the datatypes, e.g Bool(znam="1", onam="1") or Float(prec=0). We need to be able to add epics specific information too, for example EGU, DESC.

I suggest that we create a new optional kwarg on either the datatypes or attributes:configuration=. This will be an child of a new abstract class to describe further information about the datatype. Then in the epics backend we can check for this (an EpicsIntConfiguration and set our sub fields on the record accordingly).

@GDYendell

@evalott100 evalott100 added the enhancement New feature or request label Oct 15, 2024
@GDYendell
Copy link
Contributor

I would say egu and description should both be first-class members of Attribute. I would like to avoid passing around a dict of EPICS fields that don't mean anything to other backends.

@evalott100
Copy link
Contributor Author

I suppose egu will have to live in Float and Int since it's an aIn/aOut/longIn/longOut specific field. I'll make a new branch and use my best judgement as to what should live where.

@GDYendell
Copy link
Contributor

I think we shouldn't couple it to what EPICS does - backend would still be able to only pass through egu for the record types that support it. But yes, in this case egu on string and bool would never make sense, so I think you are right it needs to go on the type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants