Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings on boot if gonio axes values are not set #46

Open
GDYendell opened this issue Sep 2, 2024 · 2 comments
Open

Warnings on boot if gonio axes values are not set #46

GDYendell opened this issue Sep 2, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@GDYendell
Copy link
Contributor

GDYendell commented Sep 2, 2024

If they are set then it works fine because the fetch returns a float.

Failed to get detector/api/1.8.0/config/phi_increment:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/kappa_start:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/phi_start:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/chi_increment:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/chi_start:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/kappa_increment:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/omega_start:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/omega_increment:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/two_theta_increment:
TypeError float() argument must be a string or a real number, not 'NoneType'
Failed to get detector/api/1.8.0/config/two_theta_start:
TypeError float() argument must be a string or a real number, not 'NoneType'

Check if this happens with a real detector. If the real detector returns None, then we need to handle it correctly. If it is just the simulator then that should be fixed.

Steps To Reproduce

With sim

  1. Start tickit simulator
  2. Start IOC

or with real detector

  1. Re-initialise the detector
  2. Check what values these parameters have with curl
    • e.g. curl -v http://ixx-eiger01/detector/api/1.8.0/config/phi_start
  3. Start IOC

Acceptance Criteria

  • No warnings on boot
@GDYendell GDYendell added the bug Something isn't working label Sep 2, 2024
@GDYendell GDYendell added the good first issue Good for newcomers label Oct 18, 2024
@GDYendell
Copy link
Contributor Author

I don't seem to be able to reproduce this with the sim currently...

@GDYendell GDYendell moved this from Current Sprint to Backlog in FastCS Development Nov 28, 2024
@GDYendell
Copy link
Contributor Author

GDYendell commented Feb 11, 2025

Got this deploying to i03:

❯ ec logs bl03i-ea-eiger-02
INFO: PVXS QSRV2 is loaded, permitted, and ENABLED.
Starting iocInit
############################################################################
## EPICS 7.0.7.1-DEV
## Rev. 7.0.7.99.1.1
## Rev. Date 7.0.7.99.1.1
############################################################################
Failed to get detector/api/1.8.0/config/total_flux:
TypeError float() argument must be a string or a real number, not 'NoneType'
iocRun: All initialization complete
Python 3.11.10 (main, Nov 12 2024, 02:25:24) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
❯ curl -v http://i03-eiger01/detector/api/1.8.0/config/total_flux
*   Trying 172.23.103.210...
* TCP_NODELAY set
* Connected to i03-eiger01 (172.23.103.210) port 80 (#0)
> GET /detector/api/1.8.0/config/total_flux HTTP/1.1
> Host: i03-eiger01
> User-Agent: curl/7.61.1
> Accept: */*
>
< HTTP/1.1 200 OK
< content-type: application/json; charset=utf-8
< date: Tue, 11 Feb 2025 09:52:53 GMT
< content-length: 55
<
{"access_mode":"rw","value":null,"value_type":"float"}

so, we do need to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant