-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add introspection of commands in odin data applications #41
Comments
You have mentioned a new type of summary attribute. Just to clarify exactly what you are thinking. This would be something like a CommandSet, which would take:
This would be generic enough so that you could for example have ["Start", "Stop"] and this reads back the writing state (0,1). Or you could have ["cmd1", "cmd2", "cmd3"...] and this would read back some state attribute relaying the current state if that was ever required. Have I understood correctly what you are thinking? |
Once we have commands being introspected, there should be a new Then we need a Possibly this will require some FastCS or pvi changes to achieve. |
Commands are now supported via odin-detector/odin-data#359, so fastcs-odin should introspect these and create Attributes.
I think we want new type of summary attribute that would allow us to create an AttrRW() that when set pokes other attributes to send the commands, and reads from an AttrR for its current state. In this case when set to 1 it would poke "start_writing", when set to 0 it would poke "stop_writing" and update its readback from "writing". This could possibly be a separate issue if it proves complicated and this one can just be for creating the PVs for individual commands.
Command
APIThe text was updated successfully, but these errors were encountered: