This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
forked from DickinsonCollege/FarmData2
-
Notifications
You must be signed in to change notification settings - Fork 36
Goble 02 html #247
Open
wpgoble
wants to merge
12
commits into
DickinsonCollege:main
Choose a base branch
from
wpgoble:goble-02-HTML
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Goble 02 html #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e#210) * Initial commit, adding seeding input data cypress test * subtask DickinsonCollege#1 Assert header has 'Data' * Check the crop dropdown list size * Testing crop dropdown * Testing for crop dropdown length * Testing for crop dropdown length * test input date element enabled and has correct default value * Cleaning cypress test * Add spec.js file for testing seeding report columns by seeding type * Add test column for Tray Seedings * Completed testing for Direct Seeding column headers * Added a test to check where proper columns are displayed in the table for "All" seeding type * Reformat Tray Seeding test to look like Direct Seeding test format * Rewrite the test for all option (checking the table columns) for better efficiency and readability * Delete unnecessary folder * Modify test for the table column for the all option. Specifically, modified the for loop that check the visibility of table headers to use cypress tag instead of using .children() for to get the header elements * delete an unnecessary folder * Standardized tests and addressed requested changes * Cleaned comments * Address PR change requests * Add test for Edit header back * Check for report table before checkbuttons and add check that the checkbuttons are not disabled --------- Co-authored-by: nathang15 <[email protected]> Co-authored-by: infantlikesprogramming <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Address #4
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.