Transplanting Report: Restoring Functionality of End-to-End Tests #578
Comments
braughtg
pushed a commit
that referenced
this issue
Jan 18, 2023
__Pull Request Description__ Closes #562. This issue makes some changes to the `updateRow` function located in the Transplanting Report HTML file [[here](https://github.com/FarmData-2-Dev-Team-2022/FarmData2/blob/fixTransplantingBackend/farmdata2/farmdata2_modules/fd2_barn_kit/transplantingReport/transplantingReport.html)]. These changes are not accompanied by any Cypress e2e testing as that is a separate issue to be addressed in issue #578. As a result, these changes have been tested by sight using Hoppscotch. Additionally, this PR makes a quick fix of the filters for both the Seeding Report and Transplanting Report where editing once would permanently disable the filters until the page was refreshed because the name of the edit cancellation event was changed and the pages were not updated accordingly to reflect this change. This PR also brings up the topic of #585 (and #466) of what should be edit-able. I disabled the ability to edit `bed feet` in the Transplanting Report because transplanting logs don't have quantity data for `bed feet` but also enabled the ability to edit `row/bed` because that does exist in the logs' quantity data. However, should users be allowed to edit that data? This is beyond the scope of this PR but wanted to quickly mention this quick thought that occurred to me whilst making this fix. --- __Licensing Certification__ FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request __I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)__ for its contents.
|
It would be worthwhile to incorporate the changes detailed in issue #566 into this issue. They're not necessary to complete the issue but doing so would provide a complete testing file using all the methods provided by the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
farmdata2_modulesdirectory on your command line./test_runner.bashcommand and follow the GUI instructions until you can run the e2e test for the Transplanting Report.Desired Behavior
This issue should preferably be addressed after #570 has been closed. That way there's a complete e2e test that works with the new table instead of having a fix here and then having to fix it again once the table has been fixed.
Due to the vnc changes, we have updated to a newer version of Cypress that is not backwards compatible with the older version we were using with the virtual machines. As a result, many of the e2e tests have ceased functioning as expected. The aim of this issue is to learn and replace/fix the problematic methods that are causing the e2e test to fail. In particular, this issue aims to address the failed functioning of the e2e test for the Transplanting Report.
The text was updated successfully, but these errors were encountered: