Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing dependencies takes too long (affects both Homebrew and Travis) #14

Open
1 of 3 tasks
Dids opened this issue Jan 15, 2019 · 4 comments
Open
1 of 3 tasks
Assignees
Labels
enhancement New feature or request

Comments

@Dids
Copy link
Owner

Dids commented Jan 15, 2019

Especially on a clean install (brew remove clobber --force && brew install --force --HEAD clobber), it takes 2 minutes to install clobber, even on the most powerful of systems.

Either this means that the current formula is ignoring the vendor/ folder, or the packr2 binary installation is what's actually taking so long.

In any case, this needs to be resolved, as everything should be bundled with the project, then built and installed, which should definitely take less than a minute total (on average anyway).

  • Fix dependency caching for Travis
  • Fix dependency caching for Bitrise
  • Fix dependency caching for Homebrew
@Dids Dids added the enhancement New feature or request label Jan 15, 2019
@Dids Dids self-assigned this Jan 15, 2019
@Dids
Copy link
Owner Author

Dids commented Jan 15, 2019

Update: I'm fairly certain that even Travis builds are still downloading dependencies, and perhaps partially ignoring the vendor/ folder?

@Dids
Copy link
Owner Author

Dids commented Jan 15, 2019

More information: make deps takes ~15 seconds in a Travis build, so it's definitely not relying entirely on the vendored modules, as it should. Caching the entire GOPATH didn't do much to improve this either.

@Dids Dids changed the title Homebrew install takes too long Installing dependencies takes too long (affects both Homebrew and Travis) Jan 15, 2019
@Dids
Copy link
Owner Author

Dids commented Jan 18, 2019

Specifically on Go v1.9, make deps takes only a second or two, but anything higher (including v1.10 and v1.11) takes over 25 seconds (70 seconds without caching).

I'm guessing this comes from v1.9 using the vendor/ folder, which anything above ignores it and downloads the packages defined in the Go module file.

@Dids
Copy link
Owner Author

Dids commented Jan 18, 2019

Attempting to solve for Travis by caching $GOPATH/{bin,pkg,src}, but ignoring anything clobber related.

UPDATE: That seems to have done it, Travis builds are now a lot faster due to the caching (and due to the Makefile now checking if packr2 is installed or not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant