ExchangeBinanceAPI.GetCompletedOrdersForAllSymbolsAsync- System.Net.WebException: 'The remote server returned an error: (400) Bad Request.'

[GonzoKK]

System.Net.WebException
HResult=0x80131509
Message=The remote server returned an error: (400) Bad Request.
Source=System
StackTrace:
at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization)
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
at ExchangeSharp.APIRequestMaker.d__4.MoveNext() in C:!Dev\ExchangeSharp-master(6)\ExchangeSharp\API\Common\APIRequestMaker.cs:line 182

https://api.binance.com/api/v3/myTrades?timestamp=1565945591561&recvWindow=60000&symbol=LINKBTC&signature=04b1c8ba3c55c7e7ebd406b346515348357f7b59b5ea28228..............

[vslee]

Thanks for filing this bug. If you could send a pull request with the solution, we'll merge it. If you don't know how, you can also post the updated code here.

[GonzoKK]

This is still on my radar, will tackle soonish

[gajewskiArek]

Not really sure what was original error since there's no responseString included in details but there's a problem with GetCompletedOrdersForAllSymbolsAsync method bacause it calls Parallel.ForEach with async lambdas. When you debug later you hit
orders.Sort((o1, o2) =>
while orders still being empty. Same problem as discussed here:

https://stackoverflow.com/questions/15136542/parallel-foreach-with-asynchronous-lambda