Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsQuantityReverted, IsPriceReverted flags #570

Open
spiritedbytes opened this issue Jan 20, 2021 · 2 comments
Open

IsQuantityReverted, IsPriceReverted flags #570

spiritedbytes opened this issue Jan 20, 2021 · 2 comments

Comments

@spiritedbytes
Copy link

Hello guys,

I am wondering if it makes sense to introduce the following two flags:

  • IsPriceReverted
  • IsQuantityReverted

Because we have a global format BASE-QUOTE and the price format is 1 base = X quote. But what if the format is reversed on an exchange? Also, the quantity format can be reversed too (in the library we specify the amounts in quote currency vs base one).

The IsPriceReverted will revert the price by dividing it by 1.
The IsQuantityReverted will revert the quantity by dividing it by price (Ask/Bid/Limit).

But I already see the MarketSymbolIsReverted flag, however, I am not sure if it's a complete substitution to the two flags I mentioned above. Do you know if it makes sense to develop these two flags?

@vslee
Copy link
Collaborator

vslee commented Jan 25, 2021

Not a bad idea. @jjxtra, what do you think?

@jjxtra
Copy link
Collaborator

jjxtra commented Jan 25, 2021

Sure sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants