Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build in Visual Studio 2017 #279

Open
lookatmike opened this issue Feb 5, 2018 · 0 comments
Open

Cannot build in Visual Studio 2017 #279

lookatmike opened this issue Feb 5, 2018 · 0 comments

Comments

@lookatmike
Copy link

When you try to load any of the solutions in the /csharp/build folder with anything other than VS2015 (or, perhaps, without at least having VS2015 installed), you'll see a bunch of errors like this for each project:

The imported project "C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Microsoft.VisualStudioVersion.v14.Common.props" was not found.

This would seem to come from the following import line that most of the projects have:

<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.VisualStudioVersion.v14.Common.props" />

That appears to be a VS2015-specific thing. Would it be possible to replace that with Microsoft.Common.props instead? Should be backwards-compatible, and would make it easier to work on the project outside of VS2015. I'll submit a PR for that, but I'm open to alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant