enhancement: Fast Find for non-searchable Models #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thanks for another PR @iksaku, really appreciate it 🙏 I've adjusted the logic a tiny bit. I think a model instance should always be returned if the hash exists instead of only returning if it has attributes. A developer may create a model with timestamps disabled and no attributes leading to an empty model, and this would lead to the |
|
v1.4.2 has been released with this patch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCANis a resource intensive and slow operation and, currently, it is the best way to implement Model searching.However, not all Models are searchable, and when dealing with non-searchable models, we could skip the unnecessary
SCANand try to retrieve the model attributes usingHGETALLdirectly, reducing the load on our Redis server(s).