Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge location_grid and location_grid_meta into one field #2494

Open
corsacca opened this issue May 28, 2024 · 0 comments · May be fixed by #2519
Open

Merge location_grid and location_grid_meta into one field #2494

corsacca opened this issue May 28, 2024 · 0 comments · May be fixed by #2519
Assignees
Labels
feature New features or functionality roadmap decision

Comments

@corsacca
Copy link
Member

the location field

  • uses the predefined dt_location_grid table to list options
  • saves the grid_id in the postmeta table for records and usermeta for users.

the location_meta field

  • uses the mapbox or the google geocoding api to list options
  • finds the corresponding location_grid and saves the grid_id in the postmeta table for records and usermeta for users.
  • saves the extra meta in the dt_location_grid_meta table (lat, lng, level, label, etc)

The location_meta field requires the location field. So in essence the location_meta in an extension of the location field. These could be considered the same field with different UI and workflows.

We ran into blocks In trying to let the admin create a location_meta field on custom post types. See pr.

A custom location_meta requires a custom location_grid and we'd like to not have to create 2 fields to make this work.

So can we build out the location field to have 2 modes: normal, or with a geolocation key.

@corsacca corsacca added roadmap decision feature New features or functionality labels May 28, 2024
@corsacca corsacca added this to D.T Dev May 28, 2024
@github-project-automation github-project-automation bot moved this to Backlog in D.T Dev May 28, 2024
@corsacca corsacca moved this from Backlog to Assigned in D.T Dev May 28, 2024
@corsacca corsacca moved this from Assigned to In Review in D.T Dev Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or functionality roadmap decision
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants