Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add LargeInt Support to Range #1202

Closed

Conversation

DJStompZone
Copy link

Summary

This pull request introduces a new LargeInt converter for command arguments in Disnake, providing a built-in way to handle large integers in command arguments.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes (❓)
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Updated Range class to support LargeInt,
Added LargeIntRangeConverter class
Let's try not to break anything shall we
@DJStompZone DJStompZone changed the title Feature/range large int Fix: Add LargeInt Support to Range Jun 22, 2024
@DJStompZone DJStompZone changed the title Fix: Add LargeInt Support to Range fix: Add LargeInt Support to Range Jun 22, 2024
@Enegg
Copy link
Contributor

Enegg commented Jun 22, 2024

#1201 😅

@DJStompZone
Copy link
Author

#1201 😅

It was the only one marked as good first issue Good for newcomers 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

combine commands.LargeInt with commands.Range
2 participants