Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove decorator check in InvokableUserCommand #1252

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

shiftinv
Copy link
Member

Summary

The sanity check for cases where both @command(default_member_permissions=) and @default_member_permissions() are used on the same callback was adjusted in #678.
Putting the @default_member_permissions() decorator below the application command decorator while also using Cog(..., *_command_attrs=...) (see example below) isn't supposed to throw an exception, and while this holds for @slash_command and @message_command, it didn't work with @user_command.

This makes all decorators work the same way.

Example:

class Misc(
    commands.Cog,
    user_command_attrs={"default_member_permissions": disnake.Permissions(32)},
):
    # this shouldn't raise.
    @commands.user_command()
    @commands.default_member_permissions(64)
    async def test(self, inter) -> None:
        await inter.send("pong!")

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added p: low Low priority t: bugfix labels Nov 26, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Nov 26, 2024
@shiftinv shiftinv merged commit f2594ee into master Nov 26, 2024
28 checks passed
@shiftinv shiftinv deleted the fix/user-command-decorator-check branch November 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant