Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename flag converter file to flag_converter to avoid conflicting with ext.commands flag classes #667

Merged
merged 2 commits into from
Jul 28, 2022
Merged

chore: rename flag converter file to flag_converter to avoid conflicting with ext.commands flag classes #667

merged 2 commits into from
Jul 28, 2022

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Jul 27, 2022 •
edited
Loading

Summary

GH-666 relies on this change

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added p: medium Medium priority s: needs review Issue/PR is awaiting reviews t: bugfix labels Jul 27, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Jul 27, 2022
@onerandomusername onerandomusername force-pushed the chore/rename-command-flags branch from 083284f to 360fcee Compare July 28, 2022 07:26
@shiftinv shiftinv enabled auto-merge (squash) July 28, 2022 12:53
@shiftinv shiftinv merged commit cddcd69 into master Jul 28, 2022
@shiftinv shiftinv deleted the chore/rename-command-flags branch July 28, 2022 12:53
@shiftinv shiftinv mentioned this pull request Jul 28, 2022
Closed
8 tasks
@shiftinv shiftinv restored the chore/rename-command-flags branch July 28, 2022 13:21
@shiftinv shiftinv deleted the chore/rename-command-flags branch July 28, 2022 13:26
@onerandomusername onerandomusername added s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation and removed s: needs review Issue/PR is awaiting reviews s: in progress Issue/PR is being worked on s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
p: medium Medium priority t: bugfix
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@onerandomusername @shiftinv