We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As discussed on discord the pgn parser of chess-library accepts this ambiguous SAN move when reading the game from #144.
It only fails later, when it cannot parse Nd4+, because internally it moved the wrong knight.
Nd4+
Ideally the parser should throw the error (and stop parsing) at the first ambiguous move, as do python-chess and lichess analysis board, for example.
The text was updated successfully, but these errors were encountered:
not a pgn parser issue but a san parser issue
Sorry, something went wrong.
feat: throw error for ambiguous moves (#147)
701f8b6
closes #145
Successfully merging a pull request may close this issue.
As discussed on discord the pgn parser of chess-library accepts this ambiguous SAN move when reading the game from #144.
It only fails later, when it cannot parse
Nd4+
, because internally it moved the wrong knight.Ideally the parser should throw the error (and stop parsing) at the first ambiguous move, as do python-chess and lichess analysis board, for example.
The text was updated successfully, but these errors were encountered: