Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgn parser accepts ambiguous Nec3 #145

Closed
robertnurnberg opened this issue Jan 22, 2025 · 1 comment · Fixed by #147
Closed

pgn parser accepts ambiguous Nec3 #145

robertnurnberg opened this issue Jan 22, 2025 · 1 comment · Fixed by #147

Comments

@robertnurnberg
Copy link
Contributor

robertnurnberg commented Jan 22, 2025

As discussed on discord the pgn parser of chess-library accepts this ambiguous SAN move when reading the game from #144.

It only fails later, when it cannot parse Nd4+, because internally it moved the wrong knight.

Ideally the parser should throw the error (and stop parsing) at the first ambiguous move, as do python-chess and lichess analysis board, for example.

@Disservin
Copy link
Owner

not a pgn parser issue but a san parser issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants