Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwapsExternal should use a separate swap fee percent #350

Open
tjcloa opened this issue Jul 30, 2021 · 0 comments
Open

SwapsExternal should use a separate swap fee percent #350

tjcloa opened this issue Jul 30, 2021 · 0 comments
Assignees
@smbsp
Labels
high priority refactoring

Comments

@tjcloa
Copy link
Contributor

tjcloa commented Jul 30, 2021 •
edited
Loading

  1. add swapsFeePercent on the protocol
  2. add function setSwapsFeePercent() to SwapsExternal module
  3. add deployment script which sets swapsFeePercent percent - set it 0.05% for testing
  4. use swapsFeePercent in SwapsExternal instead of trading fees
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smbsp smbsp

Labels
high priority refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smbsp @tjcloa