Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve difference in color between alignment column and straight double quotes #553

Closed
tangledhelix opened this issue Nov 28, 2024 · 2 comments
Assignees
Labels
code improvement Improve maintainability, consistency, etc

Comments

@tangledhelix
Copy link
Collaborator

Mentioned by @srjfoo in #544,

At least on default/dark, the highlight color for straight double quotes is either the same as the color for the column alignment highlighting, or very close. (I'd take the latter a bit darker, maybe?) Again, it may not be worth worrying about, but I thought I'd mention it.

Re-evaluate these two colors in dark mode and disambiguate them better.

@tangledhelix tangledhelix added the code improvement Improve maintainability, consistency, etc label Nov 28, 2024
@tangledhelix tangledhelix self-assigned this Nov 28, 2024
@tangledhelix
Copy link
Collaborator Author

Relates to #534

@tangledhelix
Copy link
Collaborator Author

Color review for these were reviewed/cleaned up already in #650. Due to that, and because we have a general review ticket open (#353), closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement Improve maintainability, consistency, etc
Projects
None yet
Development

No branches or pull requests

1 participant