-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapper to fit response with needed schema #25
Conversation
I think that the best person to review this mappers is @afirlejczyk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! My only direct concern here is the hardcoded fields. Not sure if that causes issues with 3rd party modules etc. But it's definitely no showstopper
Shouldn't there be at least some kind of possibility to then add custom attributes to the cast maps? Or is this then left to the user to override? |
Is there work in progress? |
You could easily use the Magento module system to overwrite a mapper classes you need to extend. |
@sandermangel @nhp I added an updated version of this PR (#49) with an approach to extend the mapping without class overwrites. It works like in the |
Add mapper in order to be able to format response according to VSF required schema.
In order to resolve: #24