Incorrect track called when music resumes in Figaro Castle

[Dizzy611]

Quoting RetroDan from the BitBucket issue #16

"Okay, I've been playing through the latest commit as of this writing, and I'm about an hour and a half in, story-wise (just hit South Figaro for the first time).
So far, there is at least one consistent instance where the wrong track plays - when the cutscene with the Matron in Figaro Castle where you choose Sabin's name finishes, the music is supposed to revert to the "Figaro Castle" theme.
Instead, it reverts to the Opening theme. I have the in-game hooks disabled for the time being, as they cause known issues, and I'm trying to avoid issues that crop up where they might be the root cause, so I'm wondering if this is part of the "Track 0" issue. I will be on the lookout for more reproducible problems of this nature, so if this is determined to be an instance-by-instance problem, there will be a roadmap of places to look. Hopefully, this is merely a small symptom of a broader issue, so that fixing that issue will also fix this."

A workaround has been implemented but this issue has not been completely fixed, as while it now plays the correct track, it plays it using the SPC instead of the MSU-1. A log of the issue from BitBucket follows:

Dylan Morrison REPO OWNER
Okay, so this is an interesting case. I don't know why for you it plays the Opening, but I've certainly figured out why it plays silence. This is one of the only instances in the entire game where the game looks at the "what was playing before this" variable used by the SPC, and uses it in determining what to play next. Since I set this variable to 51 (silence), the game then plays silence once it's finished playing Sabin.
I'm trying out a fix on my end where $1309 (the SPC's "last track set" value) will get set to whatever the MSU was last playing, when the MSU plays a new track (before it switches tracks)

2016-06-11
Dylan Morrison REPO OWNER
Interesting. Said fix worked to make it play Figaro Castle properly... but it's playing it through the SPC. It's completely circumvented the MSU-1 code for that instance. Upon switching rooms, it goes back to the MSU-1.
This implies that this section of the game is using an entirely different set of routines to play this track in this particular situation than the rest of the game uses.
I'm going to commit a patch for you, see if it at least plays the right track (even if it's the SPC version) and make sure it's not playing both the SPC version and the Opening or something at once.
Unless more instances of this behavior can be found in the game, it may be best to just have that very very brief section of the game revert to SPC for a second, rather than try to chase down an errant subroutine

2016-06-11
Dylan Morrison REPO OWNER
Patch in commit c3ca6d7. You know the drill by now.
This is probably actually a very old issue (I'd be surprised if you wouldn't find it present in the earliest Alphas) but I just didn't notice it because I always thought the bit after the sabin reveal was supposed to be poignant silence :P

2016-06-11
Dylan Morrison REPO OWNER
assigned issue to Dylan Morrison

2016-06-11
Dylan Morrison REPO OWNER
changed status to open

2016-06-11
Dylan Morrison REPO OWNER
It probably goes without saying but I would definitely appreciate being notified if you can find any other instances where the wrong track plays, especially if it's a case like this where it's supposed to go back to one track after another finishes.

2016-06-11
Retro Dan™ REPORTER
changed title to Incorrect track is called in Figaro Castle
2016-06-12

Retro Dan™ REPORTER
Well, the new commit does now play the right track, but as you suspected might occur, it plays the .spc version. So, largely subverted, but I will keep an eye out for other similar issues.
2016-06-12

Dylan Morrison REPO OWNER
I might consider that resolved for now then. I'll eventually put more effort into trying to track down that particular routine, but my focus right now is making sure that the code stays relatively at the current level of complexity while fixing bugs. I don't really want to get into hooking new routines until we've got things 100% as they are now.
2016-06-12

[Dizzy611]

I need to test to see if the workaround for issue #17 has affected this in any way.

[Dizzy611]

See issue #17 for how you can help test this.

[Dizzy611]

Second (and so far only other) occurrence of this occurs when revisiting Figaro with Sabin and Edgar in the party, when you see the second part of this story wherein Edgar tosses the coin. Upon this scene's completion, where you're at the "inn" in figaro, the SPC version of the track plays (meaning it's triggering the workaround) for a short period of time, however it's switched out for the MSU-1 version immediately after you regain control.

[Dizzy611]

This should probably be revisited now that we have a way to check what map we're on.

[edale2]

It occurs to me that you might be able to see the actual audio scripting called for in this scene with Zone Doctor CE. Might make figuring out all the peculiarities of this scene easier.

[Dizzy611]

Note to self, test this again for reproduction with current patch.