Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyerror for page_title in confirmation email #1019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix keyerror for page_title in confirmation email #1019

wants to merge 1 commit into from

Conversation

amakarudze
Copy link
Contributor

Changes in this pull request:

  • Get page_title value before string interpolation in the subject
  • Use page_title variable in the dict for string interpolation.

@amakarudze amakarudze requested a review from marksweb June 16, 2024 20:34
@amakarudze amakarudze linked an issue Jun 16, 2024 that may be closed by this pull request
KeyError: 'title' #1017
Open
@codecov Codecov
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (c4bb37e) to head (809a323).
Report is 159 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   81.25%   81.26%           
=======================================
  Files          98       98           
  Lines        2950     2951    +1     
  Branches      271      271           
=======================================
+ Hits         2397     2398    +1     
  Misses        501      501           
  Partials       52       52
Files Coverage Δ
applications/forms.py 80.68% <100.00%> (+0.22%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c1ebd...809a323. Read the comment docs.

@marksweb
Copy link
Collaborator

I can't decide if this will fix #1017 because that's referring to title not page_title and I can't see anything here where the two might mean the same thing as I think we are using page_title from the Event model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb Awaiting requested review from marksweb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: 'title'
2 participants
@amakarudze @marksweb