From f641aecd019e6a37b3bab5de1e87530756d8b109 Mon Sep 17 00:00:00 2001
From: Vladiwostok <rickvsprot@protonmail.com>
Date: Fri, 2 Feb 2024 19:41:19 +0200
Subject: [PATCH] Use DMD in NumberStyleCheck

---
 src/dscanner/analysis/numbers.d | 72 ++++++++++++++++++++-------------
 src/dscanner/analysis/run.d     | 10 +++--
 2 files changed, 50 insertions(+), 32 deletions(-)

diff --git a/src/dscanner/analysis/numbers.d b/src/dscanner/analysis/numbers.d
index 8e8d55d4..b759f634 100644
--- a/src/dscanner/analysis/numbers.d
+++ b/src/dscanner/analysis/numbers.d
@@ -5,57 +5,73 @@
 
 module dscanner.analysis.numbers;
 
-import std.stdio;
-import std.regex;
-import dparse.ast;
-import dparse.lexer;
 import dscanner.analysis.base;
-import dscanner.analysis.helpers;
-import dsymbol.scope_ : Scope;
+import dmd.tokens : TOK;
+import std.conv;
+import std.regex;
+import std.stdio;
 
 /**
  * Checks for long and hard-to-read number literals
  */
-final class NumberStyleCheck : BaseAnalyzer
+extern (C++) class NumberStyleCheck(AST) : BaseAnalyzerDmd
 {
-public:
-	alias visit = BaseAnalyzer.visit;
-
+	alias visit = BaseAnalyzerDmd.visit;
 	mixin AnalyzerInfo!"number_style_check";
 
-	/**
-	 * Constructs the style checker with the given file name.
-	 */
-	this(string fileName, const(Scope)* sc, bool skipTests = false)
+	private enum KEY = "dscanner.style.number_literals";
+	private enum string MSG = "Use underscores to improve number constant readability.";
+
+	private auto badBinaryRegex = ctRegex!(`^0b[01]{9,}`);
+	private auto badDecimalRegex = ctRegex!(`^\d{5,}`);
+
+	extern (D) this(string fileName, bool skipTests = false)
 	{
-		super(fileName, sc, skipTests);
+		super(fileName, skipTests);
 	}
 
-	override void visit(const Token t)
+	override void visit(AST.IntegerExp intExpr)
 	{
-		import std.algorithm : startsWith;
+		import dscanner.utils : readFile;
+		import dmd.errorsink : ErrorSinkNull;
+		import dmd.globals : global;
+		import dmd.lexer : Lexer;
 
-		if (isNumberLiteral(t.type) && !t.text.startsWith("0x")
-				&& ((t.text.startsWith("0b") && !t.text.matchFirst(badBinaryRegex)
-					.empty) || !t.text.matchFirst(badDecimalRegex).empty))
-		{
-			addErrorMessage(t.line, t.column, "dscanner.style.number_literals",
-					"Use underscores to improve number constant readability.");
-		}
+		auto bytes = readFile(fileName) ~ '\0';
+		bytes = bytes[intExpr.loc.fileOffset .. $];
+
+		__gshared ErrorSinkNull errorSinkNull;
+		if (!errorSinkNull)
+			errorSinkNull = new ErrorSinkNull;
+
+		scope lexer = new Lexer(null, cast(char*) bytes, 0, bytes.length, 0, 0,
+				errorSinkNull, &global.compileEnv);
+		lexer.nextToken();
+
+		auto tokenValue = lexer.token.value;
+		auto tokenText = to!string(lexer.token.ptr);
+
+		if (!isIntegerLiteral(tokenValue))
+			return;
+
+		if (!matchFirst(tokenText, badDecimalRegex).empty || !matchFirst(tokenText, badBinaryRegex).empty)
+			addErrorMessage(intExpr.loc.linnum, intExpr.loc.charnum, KEY, MSG);
 	}
 
-private:
-	auto badBinaryRegex = ctRegex!(`^0b[01]{9,}`);
-	auto badDecimalRegex = ctRegex!(`^\d{5,}`);
+	private bool isIntegerLiteral(TOK token)
+	{
+		return token >= TOK.int32Literal && token <= TOK.uns128Literal;
+	}
 }
 
 unittest
 {
 	import dscanner.analysis.config : StaticAnalysisConfig, Check, disabledConfig;
+	import dscanner.analysis.helpers : assertAnalyzerWarningsDMD;
 
 	StaticAnalysisConfig sac = disabledConfig();
 	sac.number_style_check = Check.enabled;
-	assertAnalyzerWarnings(q{
+	assertAnalyzerWarningsDMD(q{
 		void testNumbers()
 		{
 			int a;
diff --git a/src/dscanner/analysis/run.d b/src/dscanner/analysis/run.d
index 05a065b1..44058dba 100644
--- a/src/dscanner/analysis/run.d
+++ b/src/dscanner/analysis/run.d
@@ -492,10 +492,6 @@ MessageSet analyze(string fileName, const Module m, const StaticAnalysisConfig a
 		checks ~= new MismatchedArgumentCheck(fileName, moduleScope,
 		analysisConfig.mismatched_args_check == Check.skipTests && !ut);
 
-	if (moduleName.shouldRun!NumberStyleCheck(analysisConfig))
-		checks ~= new NumberStyleCheck(fileName, moduleScope,
-		analysisConfig.number_style_check == Check.skipTests && !ut);
-
 	if (moduleName.shouldRun!StyleChecker(analysisConfig))
 		checks ~= new StyleChecker(fileName, moduleScope,
 		analysisConfig.style_check == Check.skipTests && !ut);
@@ -697,6 +693,12 @@ MessageSet analyzeDmd(string fileName, ASTCodegen.Module m, const char[] moduleN
 			config.redundant_storage_classes == Check.skipTests && !ut
 		);
 
+	if (moduleName.shouldRunDmd!(NumberStyleCheck!ASTCodegen)(config))
+		visitors ~= new NumberStyleCheck!ASTCodegen(
+			fileName,
+			config.number_style_check == Check.skipTests && !ut
+		);
+
 	foreach (visitor; visitors)
 	{
 		m.accept(visitor);