Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix production environment to use proper secrets #74

Open
amcewen opened this issue Aug 2, 2022 · 2 comments
Open

Fix production environment to use proper secrets #74

amcewen opened this issue Aug 2, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@amcewen
Copy link
Member

amcewen commented Aug 2, 2022

We'll have a few things: Postgres password; admin username and password; etc. which at present are hard-coded. They should get picked up from the environment, and that should be defined properly in the production environment.

@amcewen amcewen added the bug Something isn't working label Aug 2, 2022
@helicalbytes
Copy link
Contributor

In the absence of a full username / password database (or some other authentication storage) we need to add the following 2 environment variables for the admin pages:

OPTIMISM_ADMIN_USERNAME
OPTIMISM_ADMIN_PASSWORD

The password in particular needs to be secure and be provided from a secret.

@helicalbytes
Copy link
Contributor

When we merge develop to master this will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants