Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc-14 warning #308

Open
fangzhou-xie opened this issue Jul 4, 2024 · 2 comments
Open

gcc-14 warning #308

fangzhou-xie opened this issue Jul 4, 2024 · 2 comments

Comments

@fangzhou-xie
Copy link

Thanks for the wonderful library.

I have an R package (rethnicity) that relies on frugally-deep (and hence fplus). I recently got an warning in the compilation that is related to the change in standard (since gcc-14) and wonder what would be the best way to get rid of this warning (warning: template-id not allowed for constructor in C++20).

The warning seems to suggest that it is the struct array_back_insert_iterator that has this issue.

References:

  1. C++ and ISO C++ 2017
  2. simdjson
  3. rcppsimdjson

Thanks!

@Dobiasd
Copy link
Owner

Dobiasd commented Jul 5, 2024

Thanks for the nice feedback!

I'll try to fix it and will get back to you.

@Dobiasd
Copy link
Owner

Dobiasd commented Jul 5, 2024

Do you have a minimal example to reproduce the problem?

I tried like this

#include <fplus/fplus.hpp>
#include <iostream>
int main()
{
    std::cout << fplus::show(42) << std::endl;
}
g++ -std=c++20 -Wall -Wextra -pedantic -Wshadow -Werror -Weffc++ -Wconversion -Wsign-conversion -Wctor-dtor-privacy -Wreorder -Wold-style-cast -Wparentheses main.cpp

but don't get the warnings.

Is this the wrong g++ version?

g++ --version
g++ (GCC) 14.1.1 20240701 (Red Hat 14.1.1-7)
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants