Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL based image links don't appear to be working #1

Open
RickStrahl opened this issue May 22, 2018 · 1 comment
Open

URL based image links don't appear to be working #1

RickStrahl opened this issue May 22, 2018 · 1 comment

Comments

@RickStrahl
Copy link
Member

Moving one of my Help Builder repos over to Kava Docs and one of the topics has hard coded Web image URLs like this:

![](https://weblog.west-wind.com/images/2014Windows-Live-Writer/Web-Load-Testing-West-Wind-WebSurge_EBFD/Sessions_2.png)

When this renders it ends up getting fixed up as if it were a relative file link:

<img src="https://raw.githubusercontent.com/RickStrahl/WebSurgeDocumentation/master/User-Guide/https://weblog.west-wind.com/images/2014Windows-Live-Writer/Web-Load-Testing-West-Wind-WebSurge_EBFD/Sessions_2.png">

Note the raw.githubusercontent.com bits which shouldn't be applied to any http:// or https:// links.

@RickStrahl
Copy link
Member Author

So it looks like this is happening in the Markdown Renderer that's doing plain string replace which isn't going to work for selective searching. I think this will require loading the content into HtmlAgility pack after rendering and look at links explicitly. I suspect we'll need this anyway for link parsing.

Not good though - this is slow.

Also looking at the renderer I wonder if you should be caching the Markdown Parser build pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant