Updating intersect helper to work with ManyArrays #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmurphey
force-pushed
the
intersect-many-array
branch
from
c6e56e7
to
ce6f0a3
Compare
snewcomer
reviewed
Jan 3, 2020
| for (let j = 0; j < array.length; j++) { | ||
| if (array[j] === candidate) { | ||
| if (array.objectAt(j) === candidate) { |
There was a problem hiding this comment.
One question @gmurphey before merging - what makes this code as is on master not able to work with Ember arrays?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Currently the
intersecthelper returns an empty array when using an Ember Data has many relationship. This PR updates the way intersections are tested and accesses the members of a given array in a consistent and predictable way.Thanks for the great addon!