Remove action bubbling #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteto
force-pushed
the
feature/58-remove-bubbling
branch
from
8b677b3
to
2f4d754
Compare
poteto
force-pushed
the
feature/58-remove-bubbling
branch
from
69c71b5
to
aee52fb
Compare
- Add typescript comments - Update readme - Drop 1.13 support
poteto
force-pushed
the
feature/58-remove-bubbling
branch
from
aee52fb
to
67b8506
Compare
rwjblue
reviewed
May 10, 2017
| ``` | ||
|
|
||
| If no action is found after bubbling, an error will be raised. The `route-action` also has a return value: | ||
| If no action is found, an error will be raised. The `route-action` also has a return value: |
There was a problem hiding this comment.
Might want to say "found in the current route"?
| @@ -65,7 +47,7 @@ You may also use in conjunction with the `{{action}}` helper: | |||
|
|
|||
| ## Compatibility | |||
|
|
|||
| This addon will work on Ember versions `1.13.x` and up only, due to use of the new `Helper` implementation. | |||
| This addon will work on Ember versions `2.x` and up only. | |||
There was a problem hiding this comment.
If we are going for "breaking changes" maybe we can just say 2.4?
| @@ -1,3 +1,4 @@ | |||
| // @ts-nocheck | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatively large re-write that removes action bubbling. When looking up handler infos we constrain to the current route and its
indexsubroute, if present. We then look for an action fromrouteName.indextorouteName(in that order). Therefore, ifrouteName.indexhas an action, it takes precedence overrouteName's action of the same name.Closes #58
Closes #59