You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After the major upgrade, ember-router-scroll now by default extends EmberRouter. If this doesn't work for some apps that need to extend something other than EmberRouter, we can provide util functions to be called in the constructor to setup the listeners.
I'm unsure who this might apply to so filing an issue for now.
I'm unsure who this might apply to so filing an issue for now.
I just came across an IMHO very important use case for having a different solution other than extending from EmberRouter, as @embroider/router also requires this. Having said that, it seems that #255 will achieve the same, without having to expose utils...
After the major upgrade,
ember-router-scroll
now by default extendsEmberRouter
. If this doesn't work for some apps that need to extend something other thanEmberRouter
, we can provide util functions to be called in the constructor to setup the listeners.I'm unsure who this might apply to so filing an issue for now.
Ref #234
The text was updated successfully, but these errors were encountered: