Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide utils if don't use EmberRouter #235

Open
snewcomer opened this issue Jan 17, 2020 · 2 comments
Open

Provide utils if don't use EmberRouter #235

snewcomer opened this issue Jan 17, 2020 · 2 comments

Comments

@snewcomer
Copy link
Collaborator

After the major upgrade, ember-router-scroll now by default extends EmberRouter. If this doesn't work for some apps that need to extend something other than EmberRouter, we can provide util functions to be called in the constructor to setup the listeners.

I'm unsure who this might apply to so filing an issue for now.

Ref #234

@simonihmig
Copy link

I'm unsure who this might apply to so filing an issue for now.

I just came across an IMHO very important use case for having a different solution other than extending from EmberRouter, as @embroider/router also requires this. Having said that, it seems that #255 will achieve the same, without having to expose utils...

@rahulk94
Copy link

Seems like we can close this issue now that version 4 is out which extends the router service instead of using a custom router class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants