Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook should consume bundles being created by tsdx/rollup #465

Open
frankieyan opened this issue Mar 9, 2021 · 2 comments
Open

Storybook should consume bundles being created by tsdx/rollup #465

frankieyan opened this issue Mar 9, 2021 · 2 comments

Comments

@frankieyan
Copy link
Member

🚀 Feature request

Currently, storybook uses webpack to bundle both our components and stories together, while our dist build artifacts are being built with tsdx/rollup. This will be prone to error and may not surface issues quick enough during development. Instead, we should be relying on tsdx to build our source files (through npm start during dev), and storybook to import and consume the files built by tsdx.

@gnapse
Copy link
Contributor

gnapse commented Mar 9, 2021

In TSDX's "Quick start" section in its documentation they mention that one of the templates to create a new tsdx repo is react-with-storybook. I wonder if creating a new lib with that template will do what you seek here. And if so, I wonder if maybe we did not use that when we re-created Reactist using tsdx. Maybe we can now update out similar to the resulting config of a tsdx repo created that way.

@frankieyan
Copy link
Member Author

Related issue: jaredpalmer/tsdx#702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants