Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ColorPicker and move away from using DeprecatedDropdown #682

Open
frankieyan opened this issue Aug 15, 2022 · 0 comments
Open

Deprecate ColorPicker and move away from using DeprecatedDropdown #682

frankieyan opened this issue Aug 15, 2022 · 0 comments

Comments

@frankieyan
Copy link
Member

frankieyan commented Aug 15, 2022 •
edited
Loading

🚀 Feature request

Reported in #680 (comment)

The ColorPicker is built using the now-deprecated Dropdown component (see #680). To be able to remove the component, it needs to be re-implemented using the Menu component, or another equivalent.

This is currently used for the channel colour picker in Twist:

image

Possible implementations

Reakit's menu supported two-dimensional menus using a CompositeGroup. It is likely this is still supported in Ariakit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frankieyan