Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno support #19

Open
sant123 opened this issue Jan 24, 2022 · 4 comments
Open

Deno support #19

sant123 opened this issue Jan 24, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@sant123
Copy link

sant123 commented Jan 24, 2022

Hi, I just ported this library to support Deno and want to ask you feedback about it.

https://github.com/sant123/todoist

Hope you like it.

Enhancement description

Supports Deno, also Node.js can work on it with ESM.

The problem it solves

There is no need to load the library through ESM.sh or Skypack.

Alternatives

Didn't find any other alternatives.

Use case / screenshots

image

Additional information

Nope. Thank you.

@sant123 sant123 added the enhancement New feature or request label Jan 24, 2022
@proxi
Copy link
Member

proxi commented Feb 1, 2022

Hello @sant123 Thank you for your contribution. We are happy to see the package made available to Deno crowd.

We do not use Deno at Doist, and it seems there's no easy way to support both Node and Deno from a single codebase. Please correct me if I'm wrong. Were it possible, we'd be happy to accept a PR.

We've noticed you removed our Copyright notice from the LICENSE file. Since this is clearly a derivative work, you should keep original Copyright notice intact and add a new line.

Thank you.

@sant123
Copy link
Author

sant123 commented Feb 4, 2022

Hello @proxi thanks for your feedback. I think there is a package that may help us with that https://deno.land/x/[email protected] going to take a look on it.

Also I just updated the LICENSE file.

You welcome 😁

@sant123
Copy link
Author

sant123 commented Feb 4, 2022

Just curious if target ES5 is going to still be supported.

@sant123
Copy link
Author

sant123 commented Feb 5, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants