Task, AddTaskArgs and UpdateTaskArgs types are missing duration

[thales-fukuda]

Bug description

Task, AddTaskArgs, and UpdateTaskArgs are missing the type for duration property or related.

Expected behaviour

Task should have a duration property.

// src/types/entities.ts

// ...
export const BiggetThanZero =  Number.withConstraint(n => n > 0);

export type BiggerThanZero Static<typeof BiggerThanZero>

export const Unit = Union(Literal('minute'), Literal('day'))

export type Unit = Static<typeof Unit>

export const Duration = Record({
    amount: BiggerThanZero
    unit: Unit
})

export type Duration  = Static<typeof Duration>

export const Task = Record({
    // ...
   duration: Duration.Or(Null)
})

// ...

AddTaskArgs and UpdateTaskArgs should have a duration and duration_unit property.

// src/types/requests.ts

export type WithDuration = {
    duration: BiggerThanZero
    duration_unit: Unit
}

// ...

export type AddTaskArgs = AddTask | (AddTask & WithDuration)

// ...

export type UpdateTaskArgs = UpdateTask | (UpdateTask & WithDuration)

// ...

Is reproducible

Yes

To reproduce

api.getTask('[taskId]')
    .then((task) => {
        const duration = task.duration // <- ts-error: Property 'duration' does not exist on
                                       //  type '{ id: string; order: number. ... }'

        console.log(duration)
    })

Version information

• Package version: 2.1.2
• Node version: 18.18.0
• Bun version: 1.0.2

Additional information

There is an issue open on the Python API repository for the same thing: Doist/todoist-api-python#108

[henningmu]

Thank you for the report @thales-fukuda. Is this something you'd like to create a PR for?

[thales-fukuda]

Thank you for the report @thales-fukuda. Is this something you'd like to create a PR for?

I would be glad to contribute!

I couldn't find much information on contribution guidelines for this repository, is there something I should be aware of?

[henningmu]

Thank you. There's nothing to be aware of 👍

[thales-fukuda]

Hey @henningmu, here is the PR: #242