MySQL Dump error on some Hosting privider

[Torgalide]

Bug

Sorry for my english.

Error when using MySQL Dump on some hosting provider.
Issue is from the argument "--protocol=tcp".
In /htdocs/core/class/utils.class.php line 298, the condition "if (!empty($dolibarr_main_db_port))" will never be empty.
If no value is put in conf.php for $dolibarr_main_db_port, it'll be set to 3306 by default so the condition in /htdocs/core/class/utils.class.php line 298 will never be empty.
Only option for now is to manually remove "--protocol=tcp" from line 299 in /htdocs/core/class/utils.class.php.
That resolve the issue but it's not clean.

Environment Version

17.0.2

Environment OS

Linux 4.18.0

Environment Web server

LiteSpeed 8.1

Environment PHP

8.1.18

Environment Database

MariaDB 10.5.19

Environment URL(s)

No response

Expected and actual behavior

No response

Steps to reproduce the behavior

No response

Attached files

No response

[novazur972]

Confirmed with 19.0

[hregis]

@Torgalide @novazur972 @eldy
the problem is in file "filefunc.inc.php" in the line 147

if (empty($dolibarr_main_db_port)) {
	$dolibarr_main_db_port = 3306; // For compatibility with old configs, if not defined, we take 'mysql' type
}

If Mysql or MariaDB use socket connection, the port is 0 and not 3306 !
remove this line and try again to avoid modify "utils.class.php."

[novazur972]

Ok, works for me. This fix should be applied.
Note that you have to remove $dolibarr_main_db_port line from dolibarr/htdocs/conf/conf.php
Thanks !

[hregis]

@eldy #28482