Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing Vars and using concurrency can lead to trouble #6

Open
kalexmills opened this issue May 3, 2023 · 0 comments
Open

Exposing Vars and using concurrency can lead to trouble #6

kalexmills opened this issue May 3, 2023 · 0 comments

Comments

@kalexmills
Copy link
Collaborator

Since Vars is exposed, when map-based storage is used, if the user uses Vars in other ways, it's possible for them to come across concurrent map read/write panics. Currently this library provides no mechanism for concurrent-safe access to Vars while VirtualMachine.Run is running.

We could include a mechanism for allowing concurrent reads / writes to the variable storage while the VM is running.

See also: Frabjous-Studios/ldjam-53#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kalexmills