Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition when creating new keypairs #10

Open
koesie10 opened this issue Feb 9, 2022 · 0 comments · May be fixed by #11
Open

Race condition when creating new keypairs #10

koesie10 opened this issue Feb 9, 2022 · 0 comments · May be fixed by #11
Labels
bug Something isn't working

Comments

@koesie10
Copy link
Contributor

koesie10 commented Feb 9, 2022

When new keypairs need to be created and the current and/or keyset methods are called simultaneously, it can result in multiple keypairs for the same rotation interval.
@koesie10 koesie10 added the bug Something isn't working label Feb 9, 2022
koesie10 added a commit that referenced this issue Mar 4, 2022
@koesie10
fix: Use locking when creating new keypairs
7318fa5 
This adds an advisory lock when creating a new keypair to prevent
creating multiple keypairs for the same validity period.

References #10
koesie10 added a commit that referenced this issue Mar 7, 2022
@koesie10
fix: Use locking when creating new keypairs
85b64e2 
This adds an advisory lock when creating a new keypair to prevent
creating multiple keypairs for the same validity period.

References #10
@koesie10 koesie10 linked a pull request Mar 7, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use locking when creating new keypairs Drieam/keypairs
1 participant
@koesie10