Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Options for the Dropdown in their own type #238

Closed
jachin opened this issue Jun 23, 2023 · 0 comments · Fixed by #239
Closed

Put Options for the Dropdown in their own type #238

jachin opened this issue Jun 23, 2023 · 0 comments · Fixed by #239

Comments

@jachin
Copy link

jachin commented Jun 23, 2023

I've been seeing a lot of issues with the dropdown. An example would be #141.

I think this will be easier to work on if we can make some types for the options that should go in the drop down. The idea is that once we figure out what options should be in the dropdown we wrap that in a custom type.

This should allow some more encapsulation of some of the view logic too.

I also think there's some logic that's being repeated (for instance filtering out the selected options) that we might be able to remove.

Another way of putting this, we have a lot of functions that just operate on lists of options. If we can be more explicit about what these options are going to be used for it should make things more clear.

@jachin jachin linked a pull request Jun 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant