Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EqualableContentsProvider for SearchFragment #550

Open
takahirom opened this issue Jan 20, 2019 · 9 comments
Open

Add EqualableContentsProvider for SearchFragment #550

takahirom opened this issue Jan 20, 2019 · 9 comments

Comments

@takahirom
Copy link
Member

Kind (Required)

  • Other

Overview (Required)

  • When changing the query, it is animated.

groupie

Links

-https://qiita.com/takahirom/items/4125d7c871fad534d3c2#%E5%A4%89%E6%9B%B4%E3%82%A2%E3%83%8B%E3%83%A1%E3%83%BC%E3%82%B7%E3%83%A7%E3%83%B3%E5%95%8F%E9%A1%8C-equals--hashcode%E3%82%92%E7%84%A1%E7%90%86%E3%81%AA%E3%81%8F%E5%AE%9F%E8%A3%85%E3%81%99%E3%82%8B

@from-unknown
Copy link
Contributor

I may take some time, but can I try?

@jmatsu
Copy link
Contributor

jmatsu commented Jan 20, 2019

Yes, of course. Thank you so much. 🥇

@from-unknown
Copy link
Contributor

current status: I finished implementing EqualableContentsProvider and blinking was stopped, but text highlighting was also stopped.
I am looking for a way to solve it.

@takahirom
Copy link
Member Author

takahirom commented Jan 27, 2019

Probably you should add query to equalableContents when if contains query word for enabling text highlighting.
like this.

if(containsQuery) { query } else { null }

@from-unknown
Copy link
Contributor

Thank you for advice.
I'll try it.

@from-unknown
Copy link
Contributor

Sorry for late!
Because I have to do the other task, I will finish up this weekend.

@from-unknown
Copy link
Contributor

From my understanding, to update text highlighting, bind function must be called.
So I will implement code like when query changed and need to update text highlight, newItem and oldItem are different.

@takahirom
Copy link
Member Author

I would like to use EqualableContentsProvider for other items 🙏
I'm looking forward to your PR. 🙇

@from-unknown
Copy link
Contributor

Oops, I understand.
I will finish ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants