Skip to content

Commit

Permalink
Removed unused usings.
Browse files Browse the repository at this point in the history
Removed unneeded Repeat test attribute.
Simplified rendering methods.
  • Loading branch information
DJGosnell committed Nov 9, 2022
1 parent d8b07bd commit dfba6ff
Show file tree
Hide file tree
Showing 13 changed files with 128 additions and 289 deletions.
1 change: 0 additions & 1 deletion src/DtronixPdf.Tests/PdfDocumentTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace DtronixPdf.Tests
public class PdfDocumentTests
{
[Test]
[Repeat(500)]
public void LoadsDocument()
{
using var document = PdfDocument.Load("TestPdf.pdf", null);
Expand Down
10 changes: 2 additions & 8 deletions src/DtronixPdf.Tests/PdfPageRenderTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ public void RendererCreatesImageSize()
{
using var document = PdfDocument.Load("TestPdf.pdf", null);
using var page = document.GetPage(0);
var renderPage = page.Render(
1,
(uint)Color.White.ToArgb(),
new Boundary(0, 0, page.Width, page.Height));
var renderPage = page.Render(1);

var image = renderPage.GetImage();

Expand All @@ -35,10 +32,7 @@ public void RendererSavesImage()
{
using var document = PdfDocument.Load("TestPdf.pdf", null);
using var page = document.GetPage(0);
var renderPage = page.Render(
1,
(uint)Color.White.ToArgb(),
new Boundary(0, 0, page.Width, page.Height));
var renderPage = page.Render(1);

using var writer = File.OpenWrite("test.png");
renderPage.GetImage().Save(writer, new PngEncoder());
Expand Down
14 changes: 0 additions & 14 deletions src/DtronixPdf.Tests/PdfPageTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,6 @@ namespace DtronixPdf.Tests
{
public class PdfPageTests
{

[SetUp]
public void Setup()
{
//PDFiumCoreManager.Initialize();
}

[TearDown]
public void TearDown()
{
//PDFiumCoreManager.Destroy();
}


[Test]
public void LoadsPage()
{
Expand Down
149 changes: 0 additions & 149 deletions src/DtronixPdf/Actions/RenderPageAction.cs

This file was deleted.

13 changes: 5 additions & 8 deletions src/DtronixPdf/PDFiumManager.cs
Original file line number Diff line number Diff line change
@@ -1,28 +1,25 @@
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using DtronixCommon.Threading.Dispatcher;
using PDFiumCore;

namespace DtronixPdf
{

public class PdfiumCoreManager
public class PdfiumManager
{
private static bool IsInitialized;

private static PdfiumCoreManager _managerDefaultInstance;
public static PdfiumCoreManager Default => _managerDefaultInstance ??= new PdfiumCoreManager();
private static PdfiumManager _managerDefaultInstance;
public static PdfiumManager Default => _managerDefaultInstance ??= new PdfiumManager();

private readonly PdfActionSynchronizer _synchronizer;

private readonly List<PdfDocument> LoadedDocuments = new ();

private static readonly ConcurrentBag<PdfiumCoreManager> LoadedManagers = new ();
private static readonly ConcurrentBag<PdfiumManager> LoadedManagers = new ();

private PdfiumCoreManager()
private PdfiumManager()
{
LoadedManagers.Add(this);

Expand Down
5 changes: 0 additions & 5 deletions src/DtronixPdf/PdfActionSynchronizer.cs
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using DtronixCommon.Threading.Dispatcher;

namespace DtronixPdf
{
Expand Down
4 changes: 0 additions & 4 deletions src/DtronixPdf/PdfBitmap.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
using System;
using System.Threading.Tasks;
using DtronixCommon;
using DtronixCommon.Threading.Dispatcher;
using DtronixCommon.Threading.Dispatcher.Actions;
using PDFiumCore;

namespace DtronixPdf
Expand Down Expand Up @@ -31,7 +28,6 @@ public class PdfBitmap : IDisposable
/// Only call within the synchronizer since dll calls are made.
/// </summary>
/// <param name="pdfBitmap"></param>
/// <param name="image"></param>
/// <param name="synchronizer"></param>
/// <param name="scale"></param>
/// <param name="viewport"></param>
Expand Down
21 changes: 6 additions & 15 deletions src/DtronixPdf/PdfDocument.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
using System;
using System.Diagnostics;
using System.IO;
using System.Runtime.InteropServices;
using System.Threading;
using System.Threading.Tasks;
using PDFiumCore;


Expand All @@ -24,15 +21,12 @@ private PdfDocument(PdfActionSynchronizer synchronizer, FpdfDocumentT instance)
{
Synchronizer = synchronizer;
Instance = instance;
PdfiumCoreManager.Default.AddDocument(this);
PdfiumManager.Default.AddDocument(this);
}

public static PdfDocument Load(
string path,
string password,
CancellationToken cancellationToken = default)
public static PdfDocument Load(string path, string password)
{
PdfiumCoreManager.Initialize();
PdfiumManager.Initialize();

var synchronizer = new PdfActionSynchronizer();

Expand All @@ -48,10 +42,7 @@ public static PdfDocument Load(

}

public static unsafe PdfDocument Load(
Stream stream,
string password,
CancellationToken cancellationToken = default)
public static unsafe PdfDocument Load(Stream stream, string password)
{
var synchronizer = new PdfActionSynchronizer();

Expand All @@ -67,7 +58,7 @@ public static unsafe PdfDocument Load(
while ((readLength = stream.Read(ptrSpan)) > 0)
ptrSpan = ptrSpan.Slice(readLength);

PdfiumCoreManager.Initialize();
PdfiumManager.Initialize();

int pages = -1;
var result = synchronizer.SyncExec(() =>
Expand Down Expand Up @@ -185,7 +176,7 @@ public unsafe void Dispose()

Synchronizer.SyncExec(() => fpdfview.FPDF_CloseDocument(Instance));

PdfiumCoreManager.Default.RemoveDocument(this);
PdfiumManager.Default.RemoveDocument(this);

// Free the native memory.
if (_documentPointer != null)
Expand Down
5 changes: 1 addition & 4 deletions src/DtronixPdf/PdfPage.Edit.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
using System;
using System.Threading.Tasks;
using Mono.TextTemplating;
using PDFiumCore;
using PDFiumCore;

namespace DtronixPdf
{
Expand Down
Loading

0 comments on commit dfba6ff

Please sign in to comment.