Skip to content

Commit

Permalink
Added more detailed method names.
Browse files Browse the repository at this point in the history 
Fixed warning.
  • Loading branch information
@DJGosnell
DJGosnell committed Aug 24, 2023
1 parent c3a25d7 commit 84af107
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 31 deletions.
1 change: 0 additions & 1 deletion src/NexNet.IntegrationTests/BaseTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public virtual void TearDown()
CurrentPath = null;
CurrentTcpPort = null;
CurrentUdpPort = null;
_logger = null;
}

protected ServerConfig CreateServerConfigWithLog(Type type, INexusLogger? logger = null)
Expand Down
28 changes: 14 additions & 14 deletions src/NexNet.IntegrationTests/NexusClientTests_NexusDuplexPipe.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ internal class NexusClientTests_NexusDuplexPipe : BasePipeTests
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderReceivesDataMultipleTimes(Type type)
public async Task Client_PipeReaderReceivesDataMultipleTimes(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
int count = 0;

// Ensure that the ids will properly wrap around.
const int iterations = 1000;
const int iterations = 400;
cNexus.ClientTaskValueWithDuplexPipeEvent = async (nexus, pipe) =>
{
var result = await pipe.Input.ReadAsync();
Expand Down Expand Up @@ -48,7 +48,7 @@ public async Task PipeReaderReceivesDataMultipleTimes(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderReceivesData(Type type)
public async Task Client_PipeReaderReceivesData(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -73,7 +73,7 @@ public async Task PipeReaderReceivesData(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterSendsData(Type type)
public async Task Client_PipeWriterSendsData(Type type)
{
var (_, sNexus, _, cNexus, _) = await Setup(type);

Expand All @@ -95,7 +95,7 @@ public async Task PipeWriterSendsData(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderCompletesUponPipeCompleteAsync(Type type)
public async Task Client_PipeReaderCompletesUponPipeCompleteAsync(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -119,7 +119,7 @@ public async Task PipeReaderCompletesUponPipeCompleteAsync(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterCompletesUponCompleteAsync(Type type)
public async Task Client_PipeWriterCompletesUponCompleteAsync(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
cNexus.ClientTaskValueWithDuplexPipeEvent = async (nexus, pipe) =>
Expand Down Expand Up @@ -152,7 +152,7 @@ public async Task PipeWriterCompletesUponCompleteAsync(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderCompletesUponDisconnection(Type type)
public async Task Client_PipeReaderCompletesUponDisconnection(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -177,7 +177,7 @@ public async Task PipeReaderCompletesUponDisconnection(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterCompletesUponDisconnection(Type type)
public async Task Client_PipeWriterCompletesUponDisconnection(Type type)
{
var tcsDisconnected = new TaskCompletionSource();
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
Expand Down Expand Up @@ -207,7 +207,7 @@ await sNexus.Context.Clients.Caller.ClientTaskValueWithDuplexPipe(pipe).AsTask()
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderCompletesUponWriterCompletion(Type type)
public async Task Client_PipeReaderCompletesUponWriterCompletion(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -233,7 +233,7 @@ public async Task PipeReaderCompletesUponWriterCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterCompletesUponWriterCompletion(Type type)
public async Task Client_PipeWriterCompletesUponWriterCompletion(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand Down Expand Up @@ -264,7 +264,7 @@ public async Task PipeWriterCompletesUponWriterCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterRemainsOpenUponOtherWriterCompletion(Type type)
public async Task Client_PipeWriterRemainsOpenUponOtherWriterCompletion(Type type)
{
var (_, sNexus, _, cNexus, _) = await Setup(type);

Expand All @@ -291,7 +291,7 @@ public async Task PipeWriterRemainsOpenUponOtherWriterCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderRemainsOpenUponOtherReaderCompletion(Type type)
public async Task Client_PipeReaderRemainsOpenUponOtherReaderCompletion(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
var outputComplete = new TaskCompletionSource();
Expand Down Expand Up @@ -327,7 +327,7 @@ public async Task PipeReaderRemainsOpenUponOtherReaderCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeNotifiesWhenReady(Type type)
public async Task Client_PipeNotifiesWhenReady(Type type)
{
var (_, sNexus, _, cNexus, _) = await Setup(type);

Expand All @@ -348,7 +348,7 @@ public async Task PipeNotifiesWhenReady(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReadyCancelsOnDisconnection(Type type)
public async Task Client_PipeReadyCancelsOnDisconnection(Type type)
{
var (server, _, client, _, _) = await Setup(type, true);

Expand Down
31 changes: 15 additions & 16 deletions src/NexNet.IntegrationTests/NexusServerTests_NexusDuplexPipe.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@ namespace NexNet.IntegrationTests;

internal class NexusServerTests_NexusDuplexPipe : BasePipeTests
{

[TestCase(Type.Uds)]
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderReceivesDataMultipleTimes(Type type)
public async Task Server_PipeReaderReceivesDataMultipleTimes(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
int count = 0;
Expand Down Expand Up @@ -49,7 +48,7 @@ public async Task PipeReaderReceivesDataMultipleTimes(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderReceivesData(Type type)
public async Task Server_PipeReaderReceivesData(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -73,7 +72,7 @@ public async Task PipeReaderReceivesData(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterSendsData(Type type)
public async Task Server_PipeWriterSendsData(Type type)
{
var (_, sNexus, _, cNexus, _) = await Setup(type);

Expand All @@ -95,7 +94,7 @@ public async Task PipeWriterSendsData(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderCompletesUponCompleteAsync(Type type)
public async Task Server_PipeReaderCompletesUponCompleteAsync(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -119,7 +118,7 @@ public async Task PipeReaderCompletesUponCompleteAsync(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterCompletesUponCompleteAsync(Type type)
public async Task Server_PipeWriterCompletesUponCompleteAsync(Type type)
{
//Console.WriteLine("Starting test");
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
Expand Down Expand Up @@ -160,7 +159,7 @@ public async Task PipeWriterCompletesUponCompleteAsync(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderCompletesUponDisconnection(Type type)
public async Task Server_PipeReaderCompletesUponDisconnection(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -186,7 +185,7 @@ await cNexus.Context.Proxy.ServerTaskValueWithDuplexPipe(pipe).AsTask()
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterCompletesUponDisconnection(Type type)
public async Task Server_PipeWriterCompletesUponDisconnection(Type type)
{
var tcsDisconnected = new TaskCompletionSource();
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
Expand Down Expand Up @@ -216,7 +215,7 @@ await cNexus.Context.Proxy.ServerTaskValueWithDuplexPipe(pipe).AsTask()
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderCompletesUponWriterCompletion(Type type)
public async Task Server_PipeReaderCompletesUponWriterCompletion(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand All @@ -241,7 +240,7 @@ public async Task PipeReaderCompletesUponWriterCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterCompletesUponWriterCompletion(Type type)
public async Task Server_PipeWriterCompletesUponWriterCompletion(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand Down Expand Up @@ -273,7 +272,7 @@ public async Task PipeWriterCompletesUponWriterCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeWriterRemainsOpenUponOtherWriterCompletion(Type type)
public async Task Server_PipeWriterRemainsOpenUponOtherWriterCompletion(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);

Expand Down Expand Up @@ -301,7 +300,7 @@ public async Task PipeWriterRemainsOpenUponOtherWriterCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReaderRemainsOpenUponOtherReaderCompletion(Type type)
public async Task Server_PipeReaderRemainsOpenUponOtherReaderCompletion(Type type)
{
var (_, sNexus, _, cNexus, tcs) = await Setup(type);
var outputComplete = new TaskCompletionSource();
Expand Down Expand Up @@ -338,7 +337,7 @@ public async Task PipeReaderRemainsOpenUponOtherReaderCompletion(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeNotifiesWhenReady(Type type)
public async Task Server_PipeNotifiesWhenReady(Type type)
{
var (_, sNexus, _, cNexus, _) = await Setup(type);

Expand All @@ -359,7 +358,7 @@ public async Task PipeNotifiesWhenReady(Type type)
[TestCase(Type.Tcp)]
[TestCase(Type.TcpTls)]
[TestCase(Type.Quic)]
public async Task PipeReadyCancelsOnDisconnection(Type type)
public async Task Server_PipeReadyCancelsOnDisconnection(Type type)
{
var (_, sNexus, client, _, _) = await Setup(type);

Expand All @@ -378,7 +377,7 @@ public async Task PipeReadyCancelsOnDisconnection(Type type)
}

[Test]
public async Task PipesThrowWhenInvokingOnMultipleConnections()
public async Task Server_PipesThrowWhenInvokingOnMultipleConnections()
{
var (_, sNexus, _, cNexus, tcs) = await Setup(Type.Uds);
await AssertThrows<InvalidOperationException>(async () =>
Expand Down Expand Up @@ -408,7 +407,7 @@ await AssertThrows<InvalidOperationException>(async () =>
}

[Test]
public async Task PipesAllowInvocationOnSingleConnections()
public async Task Server_PipesAllowInvocationOnSingleConnections()
{
var (_, sNexus, _, cNexus, tcs) = await Setup(Type.Uds);

Expand Down

0 comments on commit 84af107

Please sign in to comment.