Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use example.com subdomains instead of "real" domain names #57

Closed
wenz opened this issue Sep 19, 2024 · 0 comments · Fixed by #58
Closed

Use example.com subdomains instead of "real" domain names #57

wenz opened this issue Sep 19, 2024 · 0 comments · Fixed by #58

Comments

@wenz
Copy link
Contributor

wenz commented Sep 19, 2024

The sample code is referring to "real" domain names such as alice.com, bob.com, and email.com. I would propose to change that to, say, alice.example.com, bob.example.com, and example.com to make crystal-clear that these really are examples. Just imagine one of those domains (especially the first two) gets cybersquatted.

I've filed (and fixed) a similar issue in the Samples repository: DuendeSoftware/Samples#209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant