Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete retired keys even if they can't be unprotected #1572

Open
RolandGuijt opened this issue Jun 7, 2024 · 1 comment · May be fixed by #1608
Open

Delete retired keys even if they can't be unprotected #1572

RolandGuijt opened this issue Jun 7, 2024 · 1 comment · May be fixed by #1608
Assignees
@josephdecock
Labels
enhancement New feature or request
Milestone
7.1.0

Comments

@RolandGuijt
Copy link

With the DeleteRetiredKeys option enabled keys from any configured store are now not deleted if they can't be unprotected.
Please see the way the keys collection is built before this line of code.

Consider proceeding with the delete without unprotecting the key first (using just the "Created" property on the keystore entry)
@RolandGuijt RolandGuijt mentioned this issue Jun 7, 2024
Closed
@RolandGuijt RolandGuijt changed the title Consider to delete retired keys even if they can't be unprotected Consider deleting retired keys even if they can't be unprotected Jun 7, 2024
@brockallen
Copy link
Member

brockallen commented Jun 7, 2024 •
edited
Loading

Oh I see... hmm, ok. Something to review.

@brockallen brockallen added the bug report Bug report from a user label Sep 17, 2024
@brockallen brockallen added this to the 7.1.0 milestone Sep 17, 2024
@josephdecock josephdecock added bug Something isn't working and removed bug report Bug report from a user labels Sep 18, 2024
@josephdecock josephdecock changed the title Consider deleting retired keys even if they can't be unprotected Delete retired keys even if they can't be unprotected Sep 18, 2024
@josephdecock josephdecock added enhancement New feature or request and removed bug Something isn't working labels Sep 26, 2024
@josephdecock josephdecock linked a pull request Sep 26, 2024 that will close this issue
Open
@josephdecock josephdecock self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdecock josephdecock

Labels
enhancement New feature or request
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Delete retired keys even if they are un-unprotectable DuendeSoftware/IdentityServer
3 participants
@brockallen @josephdecock @RolandGuijt