Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding more cache header options to DiscoveryOptions #1589

Open
RolandGuijt opened this issue Sep 13, 2024 · 1 comment
Open

Consider adding more cache header options to DiscoveryOptions #1589

RolandGuijt opened this issue Sep 13, 2024 · 1 comment

Comments

@RolandGuijt
Copy link

Please see DuendeSoftware/Support#1399

@josephdecock
Copy link
Member

ASP.NET Core has lots of built in caching support that has been improving over the past few releases. There's now both ResponseCaching (http header based) and OutputCaching (new in .net 7, controlled purely server side).

Anders brought up that we might benefit from using the built in endpoint infrastructure for better observability (#1575 (comment)). I think we could get some benefit from the framework's caching implementations as well.

Of course, that's a major change with big implications. We could always just add more options. There's about a dozen cache control directives possible (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#cache_directives). Which ones would we support? Should we try to respect request headers, as the framework's Response Cache does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants