Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shockwave can push units off the map #837

Open
Chergnobarp opened this issue Sep 21, 2024 · 1 comment
Open

Shockwave can push units off the map #837

Chergnobarp opened this issue Sep 21, 2024 · 1 comment

Comments

@Chergnobarp
Copy link
Contributor

Yesterday, I pushed Achilles off the edge of the map with shockwave, which made Gehenna unwinnable.

Easy enough to check whether affected units are in bounds before unstoring them, but I wanted to check that that's the ideal solution before doing that. I'm kind of surprised that find_vacant=yes and check_passability=yes don't take care of it, so maybe it's actually a wesnoth bug.

@Dugy
Copy link
Owner

Dugy commented Sep 21, 2024

Placing a unit at a location outside of map boundaries is a valid operation that will move the unit to the recall list. Units on the recall list are considered alive. But good luck killing them to complete scenario objective.

I think a solution for this would be to create a WML tag for knockback that would simply not knock the unit back if there is no reasonable placement. I will do it when I finish some other thing that I am doing right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants