Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad step rejection #2

Open
mh510 opened this issue Aug 10, 2018 · 1 comment
Open

Bad step rejection #2

mh510 opened this issue Aug 10, 2018 · 1 comment

Comments

@mh510
Copy link

mh510 commented Aug 10, 2018

Hi Dylan, thanks for sharing. One question regarding your implementation; why are you rejecting bad steps or what's your motivation for that? I guess that the original Adam paper is not suggesting it.

@DylanMuir
Copy link
Owner

You're right, it's not suggested. I found it to empirically work better for my problems, which is why it's in the code base.

I had intended to use an option to switch this feature on and off, but didn't have time to get that working with the options system. If you manage to get that working then please submit a pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants