From 6564bd004c8070bebfd080130f72191055ab99c4 Mon Sep 17 00:00:00 2001 From: "mjk.kirschner" Date: Mon, 6 May 2024 10:53:45 -0400 Subject: [PATCH] input symbol nodes should have default names --- src/DynamoCore/Graph/Nodes/CustomNodes/Function.cs | 6 +++--- test/DynamoCoreTests/CustomNodes.cs | 6 ++++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/DynamoCore/Graph/Nodes/CustomNodes/Function.cs b/src/DynamoCore/Graph/Nodes/CustomNodes/Function.cs index 50c6c683ed2..baf8fe5e9d6 100644 --- a/src/DynamoCore/Graph/Nodes/CustomNodes/Function.cs +++ b/src/DynamoCore/Graph/Nodes/CustomNodes/Function.cs @@ -388,8 +388,8 @@ public Symbol() RegisterAllPorts(); ArgumentLacing = LacingStrategy.Disabled; - - InputSymbol = String.Empty; + //TODO localize + InputSymbol = new TypedParameter($"DefaultInputName", "var",-1,null).ToCommentNameString(); ElementResolver = new ElementResolver(); } @@ -463,7 +463,7 @@ public string InputSymbol } OnNodeModified(); - RaisePropertyChanged("InputSymbol"); + RaisePropertyChanged(nameof(InputSymbol)); } } diff --git a/test/DynamoCoreTests/CustomNodes.cs b/test/DynamoCoreTests/CustomNodes.cs index 10340b148ab..3434dc631b9 100644 --- a/test/DynamoCoreTests/CustomNodes.cs +++ b/test/DynamoCoreTests/CustomNodes.cs @@ -1423,5 +1423,11 @@ public void LooseCustomNodeShouldNotHavePackageInfoOrPackageMember() Assert.IsFalse(nodeInfo.Value.IsPackageMember); Assert.IsNull(nodeInfo.Value.PackageInfo); } + [Test] + public void InputNodeShouldHaveNameByDefault() + { + var input = new Symbol(); + Assert.NotNull(input.Parameter.Name); + } } }