Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyCurve.ByPoints fails #15414

Closed
ricardyn opened this issue Jul 31, 2024 · 6 comments
Closed

PolyCurve.ByPoints fails #15414

ricardyn opened this issue Jul 31, 2024 · 6 comments
Labels

Comments

@ricardyn
Copy link

ricardyn commented Jul 31, 2024

Dynamo Version

Dynamo Core 2.12.1.8246 and Dynamo Core 2.19.3.6394

Host

Revit 2022.1 / 2024.2

Operating System

Windows 11

What did you do?

Trying to create a PolyCurve by four points.

What did you expect to see?

The PolyCurve passing through the points

What did you see instead?

The PolyCurve.ByPoints node creating a PolyCurve connecting just points [1] and [2]. See images below.

image

image

What packages or external references (if any) were used?

No response

Stack Trace

No response

Details

No response

Copy link

Thank you for submitting the issue to us. We are sorry to see you get stuck with your workflow. While waiting for our team member to respond, please feel free to browse our forum at https://forum.dynamobim.com/ for more Dynamo related information.

@ricardyn
Copy link
Author

Below follows the graph (saved as json to load here) for you try to replicate the issue.

PolycurveByPoints.json

@avidit avidit self-assigned this Aug 1, 2024
@avidit avidit added the tracked label Aug 1, 2024 — with Slack
@avidit avidit removed their assignment Aug 1, 2024
@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Aug 1, 2024

@ricardyn the Dynamo graph you've attached has a geometry scale factor set to 10000.0. This setting corresponds to the geometry scale setting of extra large, which is known to have issues in Dynamo as it introduces a precision issue with certain geometric operations returning unreliable results. We therefore recommend users to always adhere to the Medium setting, which corresponds to a scale factor of 1.0. If you re-execute your graph with the Medium setting, it returns the rectangular polycurve as as shown:

image

@ricardyn
Copy link
Author

ricardyn commented Aug 2, 2024

Thank you for the quick answer.
I see.

Just for registering. It's not always possible to use Medium.

Several structural engineers use centimeters as units in Revit. Causing large numbers in Dynamo.

What do you suggest in those cases that do not involve change project units to run the graph and after turn units back ?

@aparajit-pratap
Copy link
Contributor

@ricardyn the geometry scaling feature was indeed introduced to solve the units issue you just highlighted above, however, it didn't turn out to be a one-size-fits-all solution. Although changing the scale setting to large/extra large for large numbers may work in some cases, it isn't guaranteed to work in all cases and therefore may have unintended consequences for some. Unfortunately, at the moment we don't have a good solution but we hope to resolve this in the future. FYI @Amoursol

@ricardyn
Copy link
Author

ricardyn commented Aug 5, 2024

@aparajit-pratap I understand. I am very grateful for the attention. Now I know what the problem is. That already has great value.
The solution here was to use another way to build PolyCurve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants