From d5d81f01652643e7d44f3ae443a2460c1439e158 Mon Sep 17 00:00:00 2001 From: reddyashish <43763136+reddyashish@users.noreply.github.com> Date: Tue, 16 Apr 2024 01:57:53 -0700 Subject: [PATCH] Fix slider localization test --- src/Libraries/CoreNodeModelsWpf/SliderViewModel.cs | 7 ++++--- test/DynamoCoreWpfTests/SliderViewModelTests.cs | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Libraries/CoreNodeModelsWpf/SliderViewModel.cs b/src/Libraries/CoreNodeModelsWpf/SliderViewModel.cs index 0905675b0ad..ff1d6915139 100644 --- a/src/Libraries/CoreNodeModelsWpf/SliderViewModel.cs +++ b/src/Libraries/CoreNodeModelsWpf/SliderViewModel.cs @@ -63,7 +63,8 @@ public T Value if (value.CompareTo(model.Min) == -1) model.Min = value; - var stepValueString = model.Step.ToString(); + double.TryParse(model.Step.ToString(), out double stepValue); + var stepValueString = stepValue.ToString(null, CultureInfo.InvariantCulture); var decimalPoints = 0; if (stepValueString.Contains('.')) { @@ -73,8 +74,8 @@ public T Value if (value is IFormattable formattableval) { var invariantString = formattableval.ToString(null,CultureInfo.InvariantCulture); - var sliderValue = Math.Round(decimal.Parse(invariantString), decimalPoints); - model.UpdateValue(new Dynamo.Graph.UpdateValueParams(nameof(Value), sliderValue.ToString())); + var sliderValue = Math.Round(decimal.Parse(invariantString, CultureInfo.InvariantCulture), decimalPoints); + model.UpdateValue(new Dynamo.Graph.UpdateValueParams(nameof(Value), sliderValue.ToString(CultureInfo.InvariantCulture))); } else { diff --git a/test/DynamoCoreWpfTests/SliderViewModelTests.cs b/test/DynamoCoreWpfTests/SliderViewModelTests.cs index 36388cb360c..184f7893716 100644 --- a/test/DynamoCoreWpfTests/SliderViewModelTests.cs +++ b/test/DynamoCoreWpfTests/SliderViewModelTests.cs @@ -140,7 +140,6 @@ public void SliderViewModel_ValueTest() /// modify the value. /// [Test] - [Category("Failure")] public void SliderViewModel_ValueTest_Localized() { //change current thread culture to German.