Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR checker and updater for Jira missing stuff #15188

Merged
merged 3 commits into from
May 6, 2024

Conversation

AlexisErazoGlobant
Copy link
Contributor

@AlexisErazoGlobant AlexisErazoGlobant commented May 3, 2024

Purpose

Sometimes authors forget to add the ticket number to the title or/and add a Jira link to the description. So I'm adding the GitHub Action to check if the Jira ticket number is missing in the title or in the description. This updates the title with the ticket number and adds a comment with the link redirecting to the Jira ticket.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

GitHub Action to check if the Jira ticket number is missing in the title or in the description. This updates the title with the ticket number and adds a comment with the link redirecting to the Jira ticket.

Reviewers

@sm6srw

FYIs

…ssing in the title or the description. It updates the title with the ticket number and adds a comment with the link redirecting to the Jira ticket.
@QilongTang
Copy link
Contributor

Is the title of this PR going to be updated with Jira ticket as well? :)

@AlexisErazoGlobant
Copy link
Contributor Author

Hi @QilongTang, it's supposed to be like that, but I think we have to wait to finish the validations to see the result. 😅

@sm6srw sm6srw self-requested a review May 3, 2024 17:57
Copy link
Contributor

@sm6srw sm6srw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did approve the new action to run. But it failed miserable. @avidit Is it something more I need to do?

Copy link

github-actions bot commented May 3, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@AlexisErazoGlobant
Copy link
Contributor Author

@sm6srw remember the error that I had in my private repo? It seems to be the same, I solved doing this in GitHub Configurations.
posible-error-solution

@sm6srw
Copy link
Contributor

sm6srw commented May 3, 2024

Yes, those are the permissions we currently have,.

@AlexisErazoGlobant
Copy link
Contributor Author

Can u re-run the job? Enabling the debug logging?

@sm6srw sm6srw requested a review from avidit May 3, 2024 19:54
@avidit
Copy link
Contributor

avidit commented May 6, 2024

I did approve the new action to run. But it failed miserable. @avidit Is it something more I need to do?

When an action id triggered in the context of PR from a fork, the secrets.GITHUB_TOKEN has read only scopes. We can merge it to master and wait for the next PR.
Then we can see if there might are issues in the action itself.

Regarding Node.js 16 deprecation, the action itself needs to be updated. @AlexisErazoGlobant Can we find alternative action in the marketplace?

@AlexisErazoGlobant
Copy link
Contributor Author

@avidit Let me check for it, previously I found another one, but it seems it's made for its own company and its own Jira links, we could check together if you guys want.

@sm6srw
Copy link
Contributor

sm6srw commented May 6, 2024

The repository for this check was recently updated to node 20 but the change has not been released yet to the marketplace. So I think we can try this one out now and add a task to update it when the new release is available.

@sm6srw sm6srw merged commit a6c07fa into DynamoDS:master May 6, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants