From 4de5d02ecf5b985167d08a8d73bbcbdcd9208094 Mon Sep 17 00:00:00 2001 From: Roberto T Date: Wed, 16 Oct 2024 14:31:47 -0600 Subject: [PATCH 1/3] Fixing Regressions Extra Node Info Instead of using a hard-coded value like 58 got the list of expected nodes names in a variable and then if the test fails log the missing nodes. --- test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs b/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs index f93fc5c51fb..916a4070d18 100644 --- a/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs +++ b/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs @@ -18,6 +18,8 @@ namespace DynamoCoreWpfTests class NodeAutoCompleteSearchTests : DynamoTestUIBase { + private readonly List expectedNodes = new List { "ByFillet", "ByFilletTangentToCurve", "ByGeometry", "ByMinimumVolume", "ByBlendBetweenCurves", "ByTangency", "ByLineAndPoint", "ByJoinedCurves", "ByThickeningCurveNormal", "ByLoft", "ByLoft", "ByLoftGuides", "BySweep", "ByLoft", "ByLoft", "ByRevolve", "BySweep", "BySweep2Rails", "ByLoft", "ByLoft", "ByPatch", "ByRevolve", "ByRuledLoft", "BySweep", "BySweep2Rails", "BuildFromLines", "BuildPipes", "ByExtrude", "ByPlaneLineAndPoint", "ByRevolve", "BySweep", "DoesIntersect", "IsAlmostEqualTo", "DistanceTo", "Intersect", "IntersectAll", "Project", "Project", "ProjectInputOnto", "ProjectInputOnto", "Split", "Trim", "SerializeAsSAB", "ClosestPointTo", "Join", "ByGroupedCurves", "SweepAsSolid", "ExportToSAT", "SweepAsSurface", "LocateSurfacesByLine", "BridgeEdgesToEdges", "BridgeEdgesToFaces", "BridgeFacesToEdges", "BridgeFacesToFaces", "CreateMatch", "ExtrudeEdgesAlongCurve", "ExtrudeFacesAlongCurve", "PullVertices" }; + [NodeDescription("This is test node with multiple output ports and types specified.")] [NodeName("node with multi type outputs")] [InPortNames("input1", "input2")] @@ -166,7 +168,9 @@ public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithSpaceInPortN // Results will be nodes that accept Line as parameter. searchViewModel.PopulateAutoCompleteCandidates(); - Assert.AreEqual(58, searchViewModel.FilteredResults.Count()); + var nodeNamesResultList = searchViewModel.FilteredResults.Select(x => x.Name).ToList(); + + Assert.AreEqual(expectedNodes.Count(), nodeNamesResultList.Count(),string.Format("Missing nodes: {0} ", string.Join(", ",expectedNodes.Except(nodeNamesResultList)))); } [Test] public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithWhiteSpaceStartingPortName() @@ -186,7 +190,9 @@ public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithWhiteSpaceSt // Results will be nodes that accept Line as parameter. searchViewModel.PopulateAutoCompleteCandidates(); - Assert.AreEqual(58, searchViewModel.FilteredResults.Count()); + var nodeNamesResultList = searchViewModel.FilteredResults.Select(x => x.Name).ToList(); + + Assert.AreEqual(expectedNodes.Count(), nodeNamesResultList.Count(), string.Format("Missing nodes: {0} ", string.Join(", ", expectedNodes.Except(nodeNamesResultList)))); } [Test] From 6101275522915b09fecb348ef9e3e82a8477781f Mon Sep 17 00:00:00 2001 From: Roberto T Date: Thu, 17 Oct 2024 12:28:48 -0600 Subject: [PATCH 2/3] Logging Regressions Extra Node Info Trying to execute the job again due that yesterday was failing due to Helix regressions (not related to this change). --- test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs b/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs index 916a4070d18..ec13c9a6916 100644 --- a/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs +++ b/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs @@ -169,7 +169,6 @@ public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithSpaceInPortN // Results will be nodes that accept Line as parameter. searchViewModel.PopulateAutoCompleteCandidates(); var nodeNamesResultList = searchViewModel.FilteredResults.Select(x => x.Name).ToList(); - Assert.AreEqual(expectedNodes.Count(), nodeNamesResultList.Count(),string.Format("Missing nodes: {0} ", string.Join(", ",expectedNodes.Except(nodeNamesResultList)))); } [Test] From b11a6eab108ed1d1d15f30608a1af1f9d18a248d Mon Sep 17 00:00:00 2001 From: Roberto T Date: Thu, 17 Oct 2024 13:50:36 -0600 Subject: [PATCH 3/3] Logging Regressions Extra Node Info re-triggering the job --- test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs b/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs index ec13c9a6916..916a4070d18 100644 --- a/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs +++ b/test/DynamoCoreWpfTests/NodeAutoCompleteSearchTests.cs @@ -169,6 +169,7 @@ public void NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithSpaceInPortN // Results will be nodes that accept Line as parameter. searchViewModel.PopulateAutoCompleteCandidates(); var nodeNamesResultList = searchViewModel.FilteredResults.Select(x => x.Name).ToList(); + Assert.AreEqual(expectedNodes.Count(), nodeNamesResultList.Count(),string.Format("Missing nodes: {0} ", string.Join(", ",expectedNodes.Except(nodeNamesResultList)))); } [Test]